-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support request blocking in devtools #6838
Comments
Second this. It could be nice if there was an option in Lighthouse to take into consideration resources blocked in the |
Would very much want this to be able to snapshot performance with/without 'tag management systems' affecting pages. |
Sorry I must have missed this, but this has already been a feature for a long time. From the CLI, |
@patrickhulce I just confirmed that the network request blocking (via devtools) is not honored by Lighthouse. I blocked the green-ish profile picture but it still shows in LH. |
Oh, sorry I should have been more specific. Yes, any settings from devtools are not honored inside Lighthouse even if the original issue supporting it "as a configuration option" is done. I'd consider the DevTools honoring piece to be a duplicate of #3753 which captures complexity of letting devtools settings flow into Lighthouse context. |
Gotcha. Sounds like we should be able to easily pass the block requests data via |
That's true we could manually grab the blocked URL patterns and just repeat those. The larger effort part is referring to the other way of solving this (and the only way to solve the network overrides piece) which is reusing the same connection in DevTools so all settings are respected instead of creating our own connection. |
related: #5423 local overrides support |
and by lowest, I mean highest priority, lowest number :) |
Feature request summary
WPT and CDT all have abilities to block specific resources in order to determine impact of inclusion/removal on page performance. It'd be useful to be able to define what resources to block for a given set of LH runs to then compare potential impact of a resource on your resulting LH metrics.
Maybe =)
What is the motivation or use case for changing this?
Devs often wonder what's the impact of a certain set of changes. This will help them validate opportunities to pursue.
How is this beneficial to Lighthouse?
It improves the ability of LH to provide continued insight to performance enhancements with a tighter feedback cycle (vs. creating a build that LH can be run against)
The text was updated successfully, but these errors were encountered: