Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA report UI nits in dark mode #6729

Closed
paulirish opened this issue Dec 5, 2018 · 6 comments
Closed

PWA report UI nits in dark mode #6729

paulirish opened this issue Dec 5, 2018 · 6 comments
Assignees

Comments

@paulirish
Copy link
Member

The group icons should be lighter colored. Performance category already got this treatment.
And the light-on-dark aliasing of the PWA badge is a little awkward. @hwikyounglee any suggestions or leave as it?

image

@brendankenny
Copy link
Member

aliasing as in just the contrast in colors at the edge and how the browser is handling the transition? Since it's svg the renderer is picking the particular antialiasing strategy.

@paulirish
Copy link
Member Author

Colors at the edge yeah. I'm only thinking we could apply some shadow/border to soften it? Dunno, it just feels a bit unpolished.

@hwikyounglee
Copy link

Can we use #9D9D9D instead of black for the PWA icons inside circles?

darktheme-group-badges

@brendankenny
Copy link
Member

those icons are data urls...I guess we could just double them up and have a dark mode version for each.

@paulirish, is there a css selector we can use to see if we're in dark mode? Or some other way?

@paulirish
Copy link
Member Author

@brendankenny
Copy link
Member

Part of #8185 and fixed in #8425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants