-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA report UI nits in dark mode #6729
Comments
aliasing as in just the contrast in colors at the edge and how the browser is handling the transition? Since it's svg the renderer is picking the particular antialiasing strategy. |
Colors at the edge yeah. I'm only thinking we could apply some shadow/border to soften it? Dunno, it just feels a bit unpolished. |
those icons are data urls...I guess we could just double them up and have a dark mode version for each. @paulirish, is there a css selector we can use to see if we're in dark mode? Or some other way? |
yah there's a selector.. and you can see the things we've done before for this: |
The group icons should be lighter colored. Performance category already got this treatment.
And the light-on-dark aliasing of the PWA badge is a little awkward. @hwikyounglee any suggestions or leave as it?
The text was updated successfully, but these errors were encountered: