-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve how HTML elements are displayed in the results table #6683
Comments
Related to this - linking to the actual element if the page is still open. Some audits do this, some don't. There's just one ticket atm for font-size: #6436. I'll probably knock this out next week. |
Just playing around a bit... showing the textContent and outerHTML. @rviscomi What do you think about how we can improve this? Master branch: Experiment: |
Text content LGTM! In the case where the anchor content is an image, I wonder if we could/should render a thumbnail of the image?? cc @AVGP |
@paulirish @hwikyounglee How do you feel about showing text content for node elements in the details table? |
Some related discussion here. Also, seems like lots of |
Are we referring to the black text e.g. Vasil, help, blocking, etc., compared to not showing them but just tags in green? The proposed design LGTM. Thanks Matt! |
@hwikyounglee Yeah, exactly. Latest screenshot is here – same thing but looks a bit different because it's after the report redesign. |
@mattzeunert does #8961 close this out or are there other proposals you'd like to see here? |
There's element screenshots as well, but I think this ticket best matches that. I created another ticket for some |
A few things that could be improved:
driver.getNodesInDocument
, or aXe)Here are two example results:
Related ticket about the node selectors we show on hover - might also benefit from some standardization: #4015
cc @rviscomi @patrickhulce
The text was updated successfully, but these errors were encountered: