Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how HTML elements are displayed in the results table #6683

Closed
mattzeunert opened this issue Nov 29, 2018 · 9 comments
Closed

Improve how HTML elements are displayed in the results table #6683

mattzeunert opened this issue Nov 29, 2018 · 9 comments
Assignees
Labels

Comments

@mattzeunert
Copy link
Contributor

A few things that could be improved:

  • UX: hide irrelevant info, make sure important info is shown (like the text content)
  • Reduce result size (by hiding irrelevant info)
  • Be more consistent across different audits (different data sources might make this difficult, e.g. expression evaluated in page, driver.getNodesInDocument, or aXe)

Here are two example results:

Related ticket about the node selectors we show on hover - might also benefit from some standardization: #4015

cc @rviscomi @patrickhulce

@connorjclark
Copy link
Collaborator

connorjclark commented Nov 30, 2018

Related to this - linking to the actual element if the page is still open. Some audits do this, some don't. There's just one ticket atm for font-size: #6436. I'll probably knock this out next week.

@mattzeunert
Copy link
Contributor Author

Just playing around a bit... showing the textContent and outerHTML.

@rviscomi What do you think about how we can improve this?

Master branch:

Screenshot 2019-03-10 at 15 11 20

Screenshot 2019-03-10 at 15 16 43

Experiment:

Screenshot 2019-03-10 at 15 09 45

Screenshot 2019-03-10 at 15 15 47

@rviscomi
Copy link
Member

Text content LGTM!

In the case where the anchor content is an image, I wonder if we could/should render a thumbnail of the image?? cc @AVGP

@mattzeunert
Copy link
Contributor Author

@paulirish @hwikyounglee How do you feel about showing text content for node elements in the details table?

@mattzeunert
Copy link
Contributor Author

mattzeunert commented Apr 11, 2019

Be more consistent across different audits (different data sources might make this difficult, e.g. expression evaluated in page, driver.getNodesInDocument, or aXe)

Some related discussion here.

Also, seems like lots of type: 'node' details renderer types don't have a path/selector at all right now.

@hwikyounglee
Copy link

@paulirish @hwikyounglee How do you feel about showing text content for node elements in the details table?

Are we referring to the black text e.g. Vasil, help, blocking, etc., compared to not showing them but just tags in green? The proposed design LGTM. Thanks Matt!

@mattzeunert
Copy link
Contributor Author

@hwikyounglee Yeah, exactly. Latest screenshot is here – same thing but looks a bit different because it's after the report redesign.

@brendankenny
Copy link
Member

@mattzeunert does #8961 close this out or are there other proposals you'd like to see here?

@mattzeunert
Copy link
Contributor Author

There's element screenshots as well, but I think this ticket best matches that.

I created another ticket for some node.snippet tweaks we want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants