Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Lantern metrics throw when no toplevel events #5875

Closed
patrickhulce opened this issue Aug 20, 2018 · 1 comment
Closed

Have Lantern metrics throw when no toplevel events #5875

patrickhulce opened this issue Aug 20, 2018 · 1 comment
Assignees

Comments

@patrickhulce
Copy link
Collaborator

So the observed metrics throw when there are no toplevel events (like happened recently)

// There should *always* be at least one top level event, having 0 typically means something is
// drastically wrong with the trace and would should just give up early and loudly.
if (!topLevelEvents.length) {
throw new Error('Could not find any top level events');
}

However, the lantern metrics never directly call this method and so were silently returning lower values instead of erroring.

@patrickhulce
Copy link
Collaborator Author

fixed by #5878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants