Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump speedline version and enable fastMode #2227

Closed
paulirish opened this issue May 11, 2017 · 2 comments · Fixed by #2230
Closed

bump speedline version and enable fastMode #2227

paulirish opened this issue May 11, 2017 · 2 comments · Fixed by #2230
Assignees

Comments

@paulirish
Copy link
Member

thx to patrick's amazing feature addition: paulirish/speedline#49

v1.2.0 https://github.com/pmdartus/speedline

@brendankenny
Copy link
Member

this is cool. What's the difference in PSI score like?

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 11, 2017

@brendankenny depends on the site

if the layout is very unstable than it can theoretically be quite different, but in practice there's a <1% deflation since differences of <1% get essentially floored until you reach a 1% difference. On several traces I tested there was not a difference at all since the frames were either identical and layout was occurring offscreen or there were significant enough changes to avoid the fast path. Ideally we should monitor this with plots and tweak as needed.

There's a much more significant change bundled with that PR for PSI than fastMode which fixes paulirish/speedline#48, but we should probably just move speedline's implementation to be in line with the one in visualmetrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants