Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.timestamps should always be in microseconds #2116

Closed
paulirish opened this issue May 1, 2017 · 1 comment · Fixed by #2454
Closed

.timestamps should always be in microseconds #2116

paulirish opened this issue May 1, 2017 · 1 comment · Fixed by #2454
Assignees

Comments

@paulirish
Copy link
Member

We x / 1000 in a number of places on these timestamp values. It's a little odd. I asked patrick if he had a guess why and he shared this punctuation-free explanation:

something (fmp maybe?) was exposed as ts / 1000 and as the metrics got collected they're all used that way but it's now this hideous monster of misunderstand why they're not the real timestamps

We should keep these integers in their original value.
We'll break pwmetrics with this change, but that's okay. :)

This is low-priority relative to everything else but we should include it in 2.0

@brendankenny brendankenny changed the title .timestamps should be true monotonic clock values .timestamps should always be in microseconds May 1, 2017
@pedro93
Copy link

pedro93 commented May 2, 2017

Cc @denar90 we should be aware of this issue when updating with the future version of LH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants