Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't truncate actual text (file names) #1975

Closed
jamesshannon opened this issue Apr 6, 2017 · 5 comments
Closed

Don't truncate actual text (file names) #1975

jamesshannon opened this issue Apr 6, 2017 · 5 comments

Comments

@jamesshannon
Copy link

Truncation of file names tends to make it really difficult to track down the source. For example:

lighthouse_report__http___www_marketwatch_com_story_stock-markets-old-friend-volatility-threatening-to-make-a-glorious-return-2017-03-24

What file is that? Where did it come from? How can I view it?

You should rely on CSS to do the truncation, and probably set the title attribute for hovering purposes. I believe that when CSS-truncated text is copied then it copies correctly. Because it's important to be able to view the file contents for greater context. Maybe it should be a link?

@ebidel
Copy link
Contributor

ebidel commented Apr 6, 2017

Using title to show the full URL on hover is a good idea. We do that in a couple of other formatters: https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/report/partials/cards.html#L5.

@patrickhulce
Copy link
Collaborator

Need better UX on displaying URLs as a whole.

@AymenLoukil
Copy link

Google speedinsight is making good selectable/copiable links when hover :)

@AymenLoukil
Copy link

Just a simple hover text would be fine to copy the url :https://www.w3schools.com/howto/tryit.asp?filename=tryhow_css_tooltip

@connorjclark
Copy link
Collaborator

connorjclark commented Dec 27, 2019

These items are now anchor elements, so it's clear what the resource is now. Closing. #9224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants