Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing references files from tsconfig.json #16214

Closed
3 tasks done
mjalav opened this issue Oct 8, 2024 · 5 comments
Closed
3 tasks done

missing references files from tsconfig.json #16214

mjalav opened this issue Oct 8, 2024 · 5 comments

Comments

@mjalav
Copy link

mjalav commented Oct 8, 2024

FAQ

URL

locally

What happened?

I did install lighthouse with npm install lighthouse and I see following references was not find in tsconfig.json

not found. The file is in the program because: Part of 'files' list in tsconfig.json

  • /cli/test/fixtures/static-server.js
  • /core/test/audits/bf-cache-test.js
  • /core/test/audits/script-treemap-data-test.js
  • /core/test/audits/third-party-cookies-test.js
  • /core/test/computed/metrics/interactive-test.js
  • /core/test/computed/tbt-impact-tasks-test.js
  • core/test/fixtures/config-plugins/lighthouse-plugin-simple/plugin-simple.js

Also in references seems like we don't have treemap folder after installing packages. got an error //treemap' not found.
"references": [
{"path": "./types/lhr/"},
{"path": "./report/"},
{"path": "./report/generator/"},
{"path": "./shared/"},
{"path": "./treemap/"},
],

What did you expect?

expected references manage properly in installed package.

What have you tried?

I did try to download lighthouse project from github and overwrite missed file to my project. That resolved the issue.

How were you running Lighthouse?

node

Lighthouse Version

12.2.1

Chrome Version

129.0.6668.90

Node Version

v22.6.0

OS

Windows

Relevant log output

No response

@mjalav mjalav added the bug label Oct 8, 2024
@mjalav mjalav changed the title missing references files from tsgonfig.json missing references files from tsconfig.json Oct 8, 2024
@adamraine
Copy link
Member

How exactly are you using the Lighthouse package. Can you provide some specific repro steps?

@mjalav
Copy link
Author

mjalav commented Oct 10, 2024

@adamraine you can create new folder in your computer and do
npm i typescript --save-dev
npm install lighthouse

Then go to node_modules\lighthouse\tsconfig.json
you can see in line 11 there is ./treemap/ folder which is not exist. same for other files that I mentioned earlier.
Screenshot 2024-10-11 102006

@adamraine
Copy link
Member

We don't publish those files in the NPM package, so a missing file in a code editor seems expected. Is this causing any other issues?

@mjalav
Copy link
Author

mjalav commented Oct 11, 2024

@adamraine no it doesn't cause any other issue.

@adamraine
Copy link
Member

I don't know if there is an easy fix, and I would prefer not to restructure or typescript setup unless there is a visible issue so I'm going to close as WAI.

@adamraine adamraine closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants