Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of lodash instead of esm version lodash-es #16212

Closed
ChristopherPHolder opened this issue Oct 6, 2024 · 1 comment
Closed

Usage of lodash instead of esm version lodash-es #16212

ChristopherPHolder opened this issue Oct 6, 2024 · 1 comment
Assignees
Labels

Comments

@ChristopherPHolder
Copy link
Contributor

Summary

In version 9.6.0 lighthouse changed the imports of lodash to reduce bundle size #13914

However since then lighthouse has migrated from CommonJS to use ESM. This means it is now able to use the esm version of lodash which is lodash-es.

I am not sure the benefit to bundle size is that large, however since it is already using esm is it not better to use the esm version of the library?

Additionally when bundle lighthouse code with esbuild i end up with this type of additional and unnecessary wrappers in the code.

image

@ChristopherPHolder
Copy link
Contributor Author

Closed by #16211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants