Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-weight Best Practices Audits #15163

Closed
adamraine opened this issue Jun 13, 2023 · 2 comments · Fixed by #15321
Closed

Re-weight Best Practices Audits #15163

adamraine opened this issue Jun 13, 2023 · 2 comments · Fixed by #15321
Assignees
Labels
11.0 cranked up to eleven P2

Comments

@adamraine
Copy link
Member

From https://bugs.chromium.org/p/chromium/issues/detail?id=1454211:

Are all of the Best Practices sub-scores equal-weighted to come up with the overall score? It seems like some should be more highly weighted than others. In particular, I'd like to call attention to the "Uses deprecated APIs" failure, which I think we should up-weight. For example, using a deprecated API would seem to be at least twice as bad as "Page has the HTML Doctype". The latter results in quirks mode, which is bad but at least specified. The former (using deprecated APIs) represents imminent site breakage. Similarly "Page has valid source maps" doesn't impact users at all, so I'd down-weight that significantly as compared to the site breaking due to deprecated APIs.

I guess I'd lobby for making the weight of "Uses deprecated APIs" at least high enough to ensure the overall "Best Practices" score is below 90, so it shows up Orange.

We should consider re-weighting some of these

@adamraine adamraine added the P2 label Jun 13, 2023
@adamraine adamraine self-assigned this Jun 13, 2023
@mfreed7
Copy link

mfreed7 commented Jun 23, 2023

Thanks for filing this! I'm hoping this is a real possibility. It would really help with all deprecation efforts, which typically hinge on developers hearing about the deprecation at all before the removal date. Dinging the lighthouse score seems to be a great place to raise that sort of awareness, and motivate folks to stop using these APIs.

@adamraine adamraine added the 11.0 cranked up to eleven label Jun 26, 2023
@adamraine adamraine mentioned this issue Jun 26, 2023
20 tasks
@mfreed7
Copy link

mfreed7 commented Aug 3, 2023

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.0 cranked up to eleven P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants