Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in fullpagescreenshot gatherer will break the entire report #14922

Closed
adamraine opened this issue Mar 22, 2023 · 1 comment · Fixed by #14981
Closed

Error in fullpagescreenshot gatherer will break the entire report #14922

adamraine opened this issue Mar 22, 2023 · 1 comment · Fixed by #14981
Assignees
@adamraine
Labels
bug P1.5 report

Comments

@adamraine
Copy link
Member

Saw this in #14920. Any error thrown in the gatherer should do.

Instead of breaking the whole report, we should just remove the screenshot stuff from the report.
@adamraine adamraine self-assigned this Mar 22, 2023
@paulirish
Copy link
Member

Ah that's good stuff. :)

image

image

This was referenced Apr 14, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamraine adamraine

Labels
bug P1.5 report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core(runner): handle erroneous screenshot GoogleChrome/lighthouse
2 participants
@paulirish @adamraine