Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lantern to use new rendererStartTime timing #14500

Closed
connorjclark opened this issue Nov 4, 2022 · 1 comment · Fixed by #15834
Closed

update lantern to use new rendererStartTime timing #14500

connorjclark opened this issue Nov 4, 2022 · 1 comment · Fixed by #15834
Assignees
@connorjclark
Labels
P1.5 simulation / lantern

Comments

@connorjclark
Copy link
Collaborator

Follow up to #14311
@connorjclark connorjclark self-assigned this Nov 4, 2022
@connorjclark connorjclark mentioned this issue Nov 4, 2022
Closed
@connorjclark connorjclark mentioned this issue Feb 26, 2024
Merged
@paulirish
Copy link
Member

I just reviewed all cases of networkNode.startTime and from my read.. literally all of them should be using the rendererStartTime. and none using networkRequestTime.

@connorjclark connorjclark mentioned this issue Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connorjclark connorjclark

Labels
P1.5 simulation / lantern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core(lantern): use rendererStartTime instead of networkRequestTime GoogleChrome/lighthouse
4 participants
@paulirish @brendankenny @connorjclark @devtools-bot