Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much precision on the DOM size audit #14422

Closed
adamraine opened this issue Oct 4, 2022 · 1 comment · Fixed by #14479
Closed

Too much precision on the DOM size audit #14422

adamraine opened this issue Oct 4, 2022 · 1 comment · Fixed by #14479
Assignees
@adamraine
Labels
P3 report

Comments

@adamraine
Copy link
Member

We shouldn't need the .0. These values will always be integers

Screen Shot 2022-10-04 at 12 46 14 PM
@shogohida shogohida mentioned this issue Oct 31, 2022
Merged
@shogohida
Copy link
Contributor

Hi @adamraine, I wanted to contribute to lighthouse so I decided to work on this issue.

I created a pull request so please review it when you have time!
#14479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamraine adamraine

Labels
P3 report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core(dom-size): display metric values as integers shogohida/lighthouse
2 participants
@adamraine @shogohida