Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed artifacts are recomputed accidentally #13411

Closed
connorjclark opened this issue Nov 23, 2021 · 0 comments · Fixed by #13430
Closed

Computed artifacts are recomputed accidentally #13411

connorjclark opened this issue Nov 23, 2021 · 0 comments · Fixed by #13430
Assignees
@brendankenny
Labels
needs-priority

Comments

@connorjclark
Copy link
Collaborator

#13393 (comment)

We often pass artifacts as the parameter to ComputedArtifact.request, and since that object is filtered based on the audit's used artifacts, we will unexpectedly redo work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendankenny brendankenny

Labels
needs-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: computed artifact keys GoogleChrome/lighthouse
3 participants
@brendankenny @connorjclark @devtools-bot