Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offscreen-images: allow eager loading within three viewports #10471

Closed
brendankenny opened this issue Mar 16, 2020 · 1 comment · Fixed by #10643
Closed

offscreen-images: allow eager loading within three viewports #10471

brendankenny opened this issue Mar 16, 2020 · 1 comment · Fixed by #10643
Labels

Comments

@brendankenny
Copy link
Member

brendankenny commented Mar 16, 2020

offscreen-images suggests lazy loading any images outside of the initial viewport (plus a little leeway on all sides).

After discussion in ampproject/amphtml#25682 and in the latest eng meeting, we've decided to bump that up to three viewports. It's still a little arbitrary, but the impact is minimal, it lines up with the leniency of other lazy loading approaches (like the very large buffer in native lazy loading), and it's arguably a better user experience.


whatwg discussion on this issue: whatwg/html#5408

@addyosmani
Copy link
Member

To add one small note from the sync: one of the nice things about the three viewports solution is that it doesn't require us to introduce special-casing for every lazy-loading solution (which could get a bit out of hand over time...). Instead, this should be lenient enough to cater for a number of approaches as Brendan mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants