From bb599129ad21ddf8b1bdc47ba09dac17438fb855 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Mon, 26 Aug 2024 14:15:30 -0700 Subject: [PATCH] hide audit --- core/config/default-config.js | 3 +- .../reports/sample-flow-result.json | 30 +++++++++---------- core/test/results/sample_v2.json | 12 ++++---- 3 files changed, 23 insertions(+), 22 deletions(-) diff --git a/core/config/default-config.js b/core/config/default-config.js index 2aeb4562cc83..d77a0f81141e 100644 --- a/core/config/default-config.js +++ b/core/config/default-config.js @@ -553,10 +553,11 @@ const defaultConfig = { // General Group {id: 'js-libraries', weight: 0, group: 'best-practices-general'}, {id: 'deprecations', weight: 5, group: 'best-practices-general'}, - {id: 'third-party-cookies', weight: 5, group: 'best-practices-general'}, {id: 'errors-in-console', weight: 1, group: 'best-practices-general'}, {id: 'valid-source-maps', weight: 0, group: 'best-practices-general'}, {id: 'inspector-issues', weight: 1, group: 'best-practices-general'}, + // Hidden audits + {id: 'third-party-cookies', weight: 0, group: 'hidden'}, ], }, 'seo': { diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json index 45163d442b6a..97ee5c96355e 100644 --- a/core/test/fixtures/user-flows/reports/sample-flow-result.json +++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json @@ -4618,11 +4618,6 @@ "weight": 5, "group": "best-practices-general" }, - { - "id": "third-party-cookies", - "weight": 5, - "group": "best-practices-general" - }, { "id": "errors-in-console", "weight": 1, @@ -4637,6 +4632,11 @@ "id": "inspector-issues", "weight": 1, "group": "best-practices-general" + }, + { + "id": "third-party-cookies", + "weight": 0, + "group": "hidden" } ], "id": "best-practices", @@ -10829,11 +10829,6 @@ "weight": 5, "group": "best-practices-general" }, - { - "id": "third-party-cookies", - "weight": 5, - "group": "best-practices-general" - }, { "id": "errors-in-console", "weight": 1, @@ -10848,6 +10843,11 @@ "id": "inspector-issues", "weight": 1, "group": "best-practices-general" + }, + { + "id": "third-party-cookies", + "weight": 0, + "group": "hidden" } ], "id": "best-practices", @@ -22477,11 +22477,6 @@ "weight": 5, "group": "best-practices-general" }, - { - "id": "third-party-cookies", - "weight": 5, - "group": "best-practices-general" - }, { "id": "errors-in-console", "weight": 1, @@ -22496,6 +22491,11 @@ "id": "inspector-issues", "weight": 1, "group": "best-practices-general" + }, + { + "id": "third-party-cookies", + "weight": 0, + "group": "hidden" } ], "id": "best-practices", diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json index 426c9f929802..e7863b4ca03e 100644 --- a/core/test/results/sample_v2.json +++ b/core/test/results/sample_v2.json @@ -6754,11 +6754,6 @@ "weight": 5, "group": "best-practices-general" }, - { - "id": "third-party-cookies", - "weight": 5, - "group": "best-practices-general" - }, { "id": "errors-in-console", "weight": 1, @@ -6773,10 +6768,15 @@ "id": "inspector-issues", "weight": 1, "group": "best-practices-general" + }, + { + "id": "third-party-cookies", + "weight": 0, + "group": "hidden" } ], "id": "best-practices", - "score": 0.36 + "score": 0.22 }, "seo": { "title": "SEO",