Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash router being removed on audit #797

Closed
evelynvieira opened this issue May 24, 2022 · 1 comment
Closed

Hash router being removed on audit #797

evelynvieira opened this issue May 24, 2022 · 1 comment

Comments

@evelynvieira
Copy link

Hi everyone.
Recently we configured the lighthouse-ci and everything was working fine. But we have some hash routers and we are going through some problems.
When we run these hash urls, the hash is removed by audits so in the output, the finalUrl is not considering what is to the right of the hash.

Example:

Requested URL: http://example.com/#/some/path
Final URL: http://example.com/

It does not matter if I am running 10 URLS with different hashes, always will be report as a single origin url in the end of audit.

I tried to run with local Chrome Canary following this similar issue but unsuccessfully.

I am using Puppeteer to authenticated private pages as it says in the documentation.

Here is my .lighthouserc.js:

const local = {
    upload: {
        target: "filesystem",
        outputDir: ".lighthouseci"
    },
    collect: {
        startServerCommand: "yarn start",
        startServerReadyPattern: "compiled successfully",
        url: urls,
        numberOfRuns: 1,
        puppeteerScript: './.lighthouse/auth.js',
        puppeteerLaunchOptions: {
            args: ["--no-sandbox"],
            disableStorageReset: true,
            defaultViewport: {
                width: 1280,
                height: 720
            }
        }
    },
    assert: {
        preset: "lighthouse:recommended",
        assertions: {
            "categories:performance": ["warn", { "minScore": 0.9 }],
            "categories:accessibility": ["error", { "minScore": 0.7 }],
            "categories:seo": ["error", { "minScore": 0.7 }]
          }
    }
}

Versions:

  "@lhci/cli": "^0.9.0",
  "puppeteer": "^14.1.0",
  "sqlite3": "^5.0.2"

Thanks for any help :D

@connorjclark
Copy link
Collaborator

This is captured in an ongoing Lighthouse issue: GoogleChrome/lighthouse#13706

I'd expect it to be resolved for LH 10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants