feat: support cjs config file extension #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to use Lighthouse CI in a project which has `"type": "module"` in their `package.json` file.
patrickhulce
reviewed
Jul 7, 2021
There was a problem hiding this comment.
thanks for filing @remcohaszing! could we add a test case for this or is it prohibitively difficult to setup?
Done. That was actually pretty straight forward. :) |
patrickhulce
approved these changes
Jul 8, 2021
This was referenced Oct 11, 2021
|
Amazing!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to use Lighthouse CI in a project which has
"type": "module"in theirpackage.jsonfile.I also looked into supporting ESM configuration files, but since
import()is asynchronous, this is a lot more work than just supporting.cjsfiles in a code base I’m not very familiar with.