Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): more gitlab build context support #568

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

candrews
Copy link
Contributor

@candrews candrews commented Mar 9, 2021

Additional support for build context environment variables provided by GitLab

See https://docs.gitlab.com/ee/ci/variables/predefined_variables.html

Additional support for build context environment variables provided by GitLab

See https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
@candrews
Copy link
Contributor Author

candrews commented Mar 9, 2021

Build failure on macOS is an unrelated networking issue with that runner.

@paulirish
Copy link
Member

@candrews haahahah what up dude!!!!!! great to see you 'round these parts. :)

@candrews
Copy link
Contributor Author

candrews commented Mar 9, 2021

@candrews haahahah what up dude!!!!!! great to see you 'round these parts. :)

Wow, how great to (virtually) run into you! I'm doing great, still busy being the change I want to see in the (software) world as best as I can, just as I've been doing since all that years ago when we last worked together :)

I hope things are going well with you!

@paulirish
Copy link
Member

@candrews that sounds like the craig i know. :) things good here, just been hacking on webperf tooling for ages. feel free to email me if i be helpful with any lighthouse-ci questions or whatever!

also geez.. first contribution to the repo is a pull request!? what a champ.


for others: craig and i worked closely together for years at a small digital agency near boston over a decade ago.

@paulirish
Copy link
Member

back to the PR...

Additional support for build context environment variables provided by GitLab

See docs.gitlab.com/ee/ci/variables/predefined_variables.html

@candrews did you run into a case where there's a meaningful difference between the provided ENV values vs the fallback git commands?
I'm happy with the changes, but just wanted to capture if there was indeed a difference.

@candrews
Copy link
Contributor Author

candrews commented Mar 9, 2021

did you run into a case where there's a meaningful difference between the provided ENV values vs the fallback git commands?

There is no meaningful difference as far as I can tell.

My goal is to eliminate the need to run git (or even have it installed), instead relying on the information provided in the GitLab CI provided environment variables.

@candrews
Copy link
Contributor Author

bump

What can I do to help move this PR along?

Thank again!

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paulirish paulirish merged commit 0c9a727 into GoogleChrome:main Mar 23, 2021
@candrews
Copy link
Contributor Author

Woo hoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants