-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): log attempts to save url map #402
feat(cli): log attempts to save url map #402
Conversation
I see why the tests are failing; because I've configured them to check for output from an upload, but that doesn't happen when GHA runs on non- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks very much @chosak this looks great! really appreciate you digging into this just a few nits on wording :)
abfb276
to
338fd60
Compare
That seems like the best path forward, hardcode the use of |
Thanks for the text suggestions, I've fixed and rebased. I'll address your slug suggestion. Aside: While doing that I noticed that some uses of "GitHub" (for example |
Those names are explicit because they're used for things that are github support only. We don't support any other providers and I consider it a bug that they can pickup anything other than github slugs :) |
338fd60
to
c3407a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks very much @chosak! 🎉
Thanks @patrickhulce! Interesting side note I discovered while working on the tests -- some of these tests won't pass locally if your Git |
Ah yeah thanks for the note I'll loosen those! :) |
Related to #250.