Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for socket path #385

Closed
MaximeHeckel opened this issue Jul 21, 2020 · 1 comment · Fixed by #389
Closed

Adding support for socket path #385

MaximeHeckel opened this issue Jul 21, 2020 · 1 comment · Fixed by #389
Labels
enhancement New feature or request help wanted Extra attention is needed P2

Comments

@MaximeHeckel
Copy link
Contributor

Hey 👋

My team and I were trying to spin up lighthouse server on Google Cloud Run instead of GKE (we think that setting up GKE might be a bit overkill for our needs) and wanted to use a Postgres instance on Google Cloud SQL to save our report data.
However since Cloud Run instances are ephemeral, we can't rely on the sqlConnectionURL to connect to Google Cloud SQL (you have to manually whitelist IPs that can initiate a connection to the DB via public IP).
We usually rely on socket paths for our DB connections and were wondering if we could start a PR on this project to allow the lighthouserc.json file to support some socket path options 😄 (we have a PoC working as I'm writing these words)

@patrickhulce patrickhulce added enhancement New feature or request help wanted Extra attention is needed P2 labels Jul 21, 2020
@patrickhulce
Copy link
Collaborator

Sure @MaximeHeckel sounds good, happy to accept a PR! I think testing might be difficult, but we can hopefully figure something out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants