Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Layout Download from Robot #153

Merged
merged 5 commits into from
Dec 15, 2024
Merged

Remote Layout Download from Robot #153

merged 5 commits into from
Dec 15, 2024

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Dec 9, 2024

Depends on wpilibsuite/allwpilib#7527

  • Adds the ability to download and merge a layout from a robot via HTTP
  • Deprecates the Shuffleboard API support as remote downloading is much more reliable and easier to maintain

Resolves #134

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 75 lines in your changes missing coverage. Please review.

Project coverage is 67.03%. Comparing base (eea7ba6) to head (4a5f6a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 53.16% 37 Missing ⚠️
lib/widgets/tab_grid.dart 47.91% 25 Missing ⚠️
lib/services/elastic_layout_downloader.dart 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   67.35%   67.03%   -0.33%     
==========================================
  Files          78       79       +1     
  Lines        8112     8194      +82     
==========================================
+ Hits         5464     5493      +29     
- Misses       2648     2701      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872
Copy link
Owner Author

Gold872 commented Dec 15, 2024

Gonna have to merge this right now to get it out in time for beta 5, but there are some unfinished tasks with this which will be added for the kickoff release:

  1. Ability to select which file to load from instead of forcing a specific name
  2. Add tab selection to elasticlib
  3. Unit tests

@Gold872 Gold872 merged commit 5ddce94 into main Dec 15, 2024
9 checks passed
@Gold872 Gold872 deleted the remote-layout-downloading branch December 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save & Load layout to robot
1 participant