From be8a2af7acf9c59405904789e339a017d0c45bb6 Mon Sep 17 00:00:00 2001 From: Gold87 <91761103+Gold872@users.noreply.github.com> Date: Tue, 15 Oct 2024 16:51:27 -0400 Subject: [PATCH 1/5] Install liblzma-dev on linux --- .github/workflows/elastic-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/elastic-ci.yml b/.github/workflows/elastic-ci.yml index 774b522d..07af07a6 100644 --- a/.github/workflows/elastic-ci.yml +++ b/.github/workflows/elastic-ci.yml @@ -105,7 +105,7 @@ jobs: if: ${{ matrix.build-option == 'linux' }} run: | sudo apt-get update -y - sudo apt-get install -y ninja-build libgtk-3-dev + sudo apt-get install -y ninja-build libgtk-3-dev liblzma-dev - name: Setup flutter uses: subosito/flutter-action@v2 @@ -158,4 +158,4 @@ jobs: with: name: ${{ matrix.artifact-name }}_installer path: "build/windows/x64/installer" - if-no-files-found: error \ No newline at end of file + if-no-files-found: error From cf0137792143d1bf5bddd10212dfd532973d09b5 Mon Sep 17 00:00:00 2001 From: Gold87 <91761103+Gold872@users.noreply.github.com> Date: Tue, 15 Oct 2024 16:59:44 -0400 Subject: [PATCH 2/5] Run flutter doctor to figure out what's wrong --- .github/workflows/elastic-ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/elastic-ci.yml b/.github/workflows/elastic-ci.yml index 07af07a6..b00881a9 100644 --- a/.github/workflows/elastic-ci.yml +++ b/.github/workflows/elastic-ci.yml @@ -105,7 +105,7 @@ jobs: if: ${{ matrix.build-option == 'linux' }} run: | sudo apt-get update -y - sudo apt-get install -y ninja-build libgtk-3-dev liblzma-dev + sudo apt-get install -y ninja-build libgtk-3-dev liblzma-dev libglu1-mesa - name: Setup flutter uses: subosito/flutter-action@v2 @@ -114,6 +114,9 @@ jobs: cache: true cache-path: ${{ runner.tool_cache }}/flutter/${{ matrix.build-option }} + - name: Flutter doctor + run: flutter doctor + - name: Install dependencies run: flutter pub get From fddcbb0928120abbf62d746970574dbac77b687b Mon Sep 17 00:00:00 2001 From: Gold87 <91761103+Gold872@users.noreply.github.com> Date: Tue, 15 Oct 2024 17:09:55 -0400 Subject: [PATCH 3/5] Use ubuntu 22.04 --- .github/workflows/elastic-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/elastic-ci.yml b/.github/workflows/elastic-ci.yml index b00881a9..8a831896 100644 --- a/.github/workflows/elastic-ci.yml +++ b/.github/workflows/elastic-ci.yml @@ -18,7 +18,7 @@ env: jobs: formatting-analysis: name: "Check Formatting & Analyze" - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Checkout repo @@ -47,7 +47,7 @@ jobs: run: flutter analyze --no-fatal-infos --no-fatal-warnings test: name: "Run Tests" - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Checkout repo @@ -87,7 +87,7 @@ jobs: artifact-path: "build/macos/Build/Products/Release/Elastic-macOS.zip" artifact-name: Elastic-macOS executable-type: portable - - os: ubuntu-latest + - os: ubuntu-22.04 build-option: "linux" artifact-path: "build/linux/x64/release/bundle" artifact-name: Elastic-Linux From 6a9b97db361600dced28b9073173a04826cdad20 Mon Sep 17 00:00:00 2001 From: Gold87 <91761103+Gold872@users.noreply.github.com> Date: Tue, 15 Oct 2024 17:20:45 -0400 Subject: [PATCH 4/5] Remove flutter doctor --- .github/workflows/elastic-ci.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/elastic-ci.yml b/.github/workflows/elastic-ci.yml index 8a831896..3cbf17e9 100644 --- a/.github/workflows/elastic-ci.yml +++ b/.github/workflows/elastic-ci.yml @@ -13,7 +13,7 @@ on: workflow_dispatch: env: - FLUTTER_VERSION: 3.22.0 + FLUTTER_VERSION: 3.22.3 jobs: formatting-analysis: @@ -114,9 +114,6 @@ jobs: cache: true cache-path: ${{ runner.tool_cache }}/flutter/${{ matrix.build-option }} - - name: Flutter doctor - run: flutter doctor - - name: Install dependencies run: flutter pub get From 153eca391fb57c1c6a5e1f7d02a4ccd015a78222 Mon Sep 17 00:00:00 2001 From: Gold87 <91761103+Gold872@users.noreply.github.com> Date: Tue, 15 Oct 2024 17:25:45 -0400 Subject: [PATCH 5/5] Remove unnecessary matrix fields --- .github/workflows/elastic-ci.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/elastic-ci.yml b/.github/workflows/elastic-ci.yml index 3cbf17e9..73c30dc4 100644 --- a/.github/workflows/elastic-ci.yml +++ b/.github/workflows/elastic-ci.yml @@ -86,12 +86,10 @@ jobs: build-option: "macos" artifact-path: "build/macos/Build/Products/Release/Elastic-macOS.zip" artifact-name: Elastic-macOS - executable-type: portable - os: ubuntu-22.04 build-option: "linux" artifact-path: "build/linux/x64/release/bundle" artifact-name: Elastic-Linux - executable-type: portable name: "Build - ${{ matrix.artifact-name }}" needs: [formatting-analysis, test] @@ -101,11 +99,11 @@ jobs: - name: Checkout repo uses: actions/checkout@v4 - - name: Install flutter dependencies + - name: Install flutter build dependencies if: ${{ matrix.build-option == 'linux' }} run: | sudo apt-get update -y - sudo apt-get install -y ninja-build libgtk-3-dev liblzma-dev libglu1-mesa + sudo apt-get install -y libglu1-mesa ninja-build libgtk-3-dev liblzma-dev - name: Setup flutter uses: subosito/flutter-action@v2