Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactables need 3D Gizmos to assist in alignment #584

Open
Malcolmnixon opened this issue Dec 10, 2023 · 0 comments · May be fixed by #585
Open

Interactables need 3D Gizmos to assist in alignment #584

Malcolmnixon opened this issue Dec 10, 2023 · 0 comments · May be fixed by #585
Assignees
@Malcolmnixon

Comments

@Malcolmnixon
Copy link
Collaborator

The Interactables (Hinge, Slider, Joystick) need 3D Gizmos to assist in alignment and configuration; however the design of the interactables currently hinders this.

The current interactable nodes move within the confines/transform of their parent "Origin" Node3D; and so visualizing the extents of motion want to be with regards to that "Origin" Node3D; however the 3D Gizmos mechanism attaches visualizations and aids to the target node.

As such a secondary set of scripts HingeOrigin, SliderOrigin, JoystickOrigin would be needed to define the extents, and the 3D Gizmos would be attached to these origin nodes.
@Malcolmnixon Malcolmnixon self-assigned this Dec 10, 2023
Malcolmnixon added a commit to Malcolmnixon/godot-xr-tools that referenced this issue Dec 10, 2023
@Malcolmnixon
Added gizmos to help align interactable joints
c29448b 
This PR resolves request GodotVR#584 by adding gizmos to align interactable hinges, sliders, and joysticks. This does cause minor breakage in that:
- New origin nodes have been introduced where the ranges are visualized
- Testing showed Y-Axis inversion on the slider and joystick
@Malcolmnixon Malcolmnixon linked a pull request Dec 10, 2023 that will close this issue
Open
Malcolmnixon added a commit to Malcolmnixon/godot-xr-tools that referenced this issue Dec 11, 2023
@Malcolmnixon
Added gizmos to help align interactable joints
5164a96 
This PR resolves request GodotVR#584 by adding gizmos to align interactable hinges, sliders, and joysticks. This does cause minor breakage in that:
- New origin nodes have been introduced where the ranges are visualized
- Testing showed Y-Axis inversion on the slider and joystick
Malcolmnixon added a commit to Malcolmnixon/godot-xr-tools that referenced this issue Dec 11, 2023
@Malcolmnixon
Added gizmos to help align interactable joints
d9c2595 
This PR resolves request GodotVR#584 by adding gizmos to align interactable hinges, sliders, and joysticks. This does cause minor breakage in that:
- New origin nodes have been introduced where the ranges are visualized
- Testing showed Y-Axis inversion on the slider and joystick
@BastiaanOlij BastiaanOlij linked a pull request Dec 11, 2023 that will close this issue
Added gizmos to help align interactable joints #585
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Malcolmnixon Malcolmnixon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added gizmos to help align interactable joints Malcolmnixon/godot-xr-tools
1 participant
@Malcolmnixon