Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Requests #34

Open
GoEddie opened this issue Dec 13, 2018 · 13 comments
Open

Feature Requests #34

GoEddie opened this issue Dec 13, 2018 · 13 comments

Comments

@GoEddie
Copy link
Owner

GoEddie commented Dec 13, 2018

If you have any feature requests, add a comment here with as much detail - when I work on the next version then I will consider them.

If you want to see a feature implemented it, add a comment with the feature number and a +1

@GoEddie
Copy link
Owner Author

GoEddie commented Dec 13, 2018

Request #1: Cover inline table valued functions

Statements inside inline table valued functions are not currently covered, the sp_statement_completed event doesn't include inline tvf's but we do get a intent-shared transaction lock so we could include those in the trace and show whether an inline tvf has at least been called. They can't contain branches in so they would either be 0% or 100% covered.

Possible issues to consider:

Do different isolation modes change the lock types?
-Can we filter to just inline tvf's?
-The current trace system wouldn't be able to cope with adding lock aquired's in, more work on the perf of that side of things would be required
-Do we always get a lock for it?

This was copied from: #30

@GoEddie
Copy link
Owner Author

GoEddie commented Dec 13, 2018

Request #2: Corbertura output files support

done - included in 0.5.0:

https://github.com/GoEddie/SQLCover/releases/tag/0.5.0

@GoEddie
Copy link
Owner Author

GoEddie commented Dec 13, 2018

Request #3: html output: navigation buttons to go to top of page

done - included in 0.5.0:

https://github.com/GoEddie/SQLCover/releases/tag/0.5.0

@GoEddie
Copy link
Owner Author

GoEddie commented Dec 19, 2018

Request #4: Sql 2019

@GoEddie
Copy link
Owner Author

GoEddie commented Dec 19, 2018

Request: #5: Sql on linux support (might just be testing)

@GoEddie
Copy link
Owner Author

GoEddie commented Oct 14, 2019

Request #6: Configure timeout

done - in 0.5.0:

https://github.com/GoEddie/SQLCover/releases/tag/0.5.0

@Athi2019
Copy link

Do we have a resolution for Request #5 please?

@GoEddie
Copy link
Owner Author

GoEddie commented Oct 16, 2019

@Athi2019 no sorry, I haven't tried covering t-sql on a sql on linux instance - if you have and it doesn't work it would be great if you can add any details of exceptions etc.

@Athi2019
Copy link

Athi2019 commented Oct 17, 2019

@GoEddie I am trying to cover t-sql on a windows sql instance . Please refer this link for the details:
https://forum.red-gate.com/discussion/85990/incorrect-sql-test-code-coverage#latest

@GoEddie
Copy link
Owner Author

GoEddie commented Oct 17, 2019

Hi @Athi2019 sorry I misunderstood, I see now :)

The issue you have is a few days work and I don’t have the capacity at the moment for that amount of OSS work.

If it is important to you and you have a budget I would be happy to discuss sponsorship to get it working for you, if you would like to pursue this please reach out to me [email protected]

Ed

@persistence911
Copy link

Please can you add an azure-pipeline examples to this repo.. I am using with Azure and I am not sure I am doing it right because report generator shows files missing when I drill down.

@lowlydba
Copy link

lowlydba commented Jul 31, 2020

Request: Output report files in UTF-8 by default.

I had issues uploading the OpenCover XML to sites like https://codecov.io since it wasn't in UTF-8. I'm now manually converting before uploading, but it would be nice if that was default or an option. A low lift would be to include this in the example .ps1 file as well.

@lastlink
Copy link
Contributor

@persistence911 there is now a github action that works, also see my open sourced project https://dev.azure.com/funktechno/_git/dotnet%20ci%20pipelines?path=%2Fazure-pipelines.yml for running a sql server instance in an azure devops pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants