Backtraces in errors

[scsmithr]

Not having backtraces is insanely frustrating.

Two options:

• Figure out how to make thiserror capture backtraces.
• Switch to a crate that supports capturing backtraces.

Should start with a minimal example to ensure backtraces are actually be captured.

[RustomMS]

This rust playground is using the thiserror example for backtrace to show how it is produced. Still requires nightly along with two features

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=8b753fb257c3ea36e5a8b3fef5f363e0

#![feature(provide_any)]
#![feature(error_generic_member_access)]

rust-lang/rust#96024
rust-lang/rust#99301

[RustomMS]

https://mmapped.blog/posts/12-rust-error-handling.html
https://github.com/influxdata/influxdb_iox/blob/d84f05b2f5eca6a3f95fb7a21f7fe48046231d88/docs/style_guide.md

The above seem to suggest a different approach than what we were taking. I am going to prototype this in PersistenceError

Draft in https://github.com/GlareDB/glaredb/blob/125ebf20d75e4dbfe7a82b1fa92da99298459d54/crates/persistence/src/errors.rs

Though I couldn't get the actual backtrace to print within the crate.

[scsmithr]

In the meantime, do more logging, instrument functions.

[scsmithr]

2023-01-03T15:40:11.071990Z DEBUG  glaredb-thread-6 ThreadId(08) glaredb_connection{conn_id=a82225e3-058a-46d5-904f-3e18f27cb73c}: glaredb::server: crates/glaredb/src/server.rs:108: client disconnected with error e=Invalid argument error: column types must match schema types, expected Float32 but found Float64 at column index 10 client_addr=127.0.0.1:64426
2023-01-03T15:40:11.103548Z DEBUG  glaredb-thread-6 ThreadId(08) glaredb_connection{conn_id=a82225e3-058a-46d5-904f-3e18f27cb73c}:pg_protocol_message{name="query"}:Connection{peer=Client}: h2::codec::framed_write: /Users/sean/.cargo/registry/src/github.com-1ecc6299db9ec823/h2-0.3.15/src/codec/framed_write.rs:232: send frame=GoAway { error_code: NO_ERROR, last_stream_id: StreamId(0) }

Closing because we have spans per connection and protocol message.