-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move documentation to sphinx-book-theme
and myst
#303
Conversation
Great initiative ! A few comments:
|
Short answers:
Well you will probably have to get used to it anyway, as it's the theme of any major PyData package: NumPy, SciPy, Dask, etc 😛 Personally, I find it on a different level (much, much better) than the ReadTheDocs theme, which is extremely narrow on modern monitors (bad use of space), unintuitive for search features, no interactive options, less customizable and less maintained... And not only the look, but the experience from coding in |
Merging now as no documentation content is changed and the final fixes are required to make tests pass. |
sphinx-book-theme
sphinx-book-theme
and myst
Nice to have both documentations updated now ! 🥳
Maybe I missed something, but I couldn't find a button to start a binder from one of the examples (e.g. this one). |
The binder works from documentation pages, but not from the gallery of examples (because those are generated by Right now, I wonder what's the best way to go about this... 😅 |
Unfortunately, sphinx-gallery + Binder does not work with readthedocs (last paragraph of the section at the link in previous comment):
Looking deeper, it looks like they are thinking of making the link easier in Looks like it is possible to somehow circumvent the problem in the meantime: https://stanczakdominik.github.io/posts/simple-binder-usage-with-sphinx-gallery-through-jupytext/ |
@adehecq @erikmannerfelt @atedstone You probably received the Readthedocs email saying that |
Thanks @rhugonnet for looking into the Binder issue. It seems quite complicated indeed and probably not worth the huge effort. Another option is to have a separate repository with some demo files, like I did for the winter school in Nepal: https://github.com/GlacioHack/xdem-demo. Each project can be a different branch. And thanks for looking into the readthedocs warning! |
This makes me think: for binder, we cannot rely on the current system anymore, they have lost most of their servers. I'll open an issue. |
This PR updates xDEM's documentation format and theme, finishes fixes with the new GeoUtils behaviour (#341) and finishes the setup of Binder.
It largely mirrors GlacioHack/geoutils#351 on all documentation aspects, see that PR for reference.
In short:
sphinx-book-theme
and the format tomyst
,/docs/source/code
used to populate some pages have been moved directly into the documentation asmyst-nb
code-cells,A couple notable addition of this PR:
xdem/docs/
intoxdem/doc/
for consistency with GeoUtils, and other packages,"dollarmath"
tomyst_enable_extensions
in the documentation configuration to represent equations,README
andCONTRIBUTING
in the same style as for GeoUtils, with several new badges.Issues solved
This PR:
Old text