Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean coreg.py #266

Closed
adehecq opened this issue May 12, 2022 · 3 comments
Closed

Clean coreg.py #266

adehecq opened this issue May 12, 2022 · 3 comments
Labels
invalid This doesn't seem right priority Needs to be fixed rapidly

Comments

@adehecq
Copy link
Member

adehecq commented May 12, 2022

There seem to be several unused functions in coreg.py, e.g.:

  • get_terrainattr
  • rio_to_rda
  • mask_as_array -> used only once in ddem.py...

It would be good to remove those if they are indeed not used anymore. @rhugonnet and @erikmannerfelt, if you give me the go, I can delete/move them as part of my next PR.
@adehecq adehecq added the invalid This doesn't seem right label May 12, 2022
@rhugonnet
Copy link
Member

Agreed! The first two functions, I moved and updated into terrain.py in #227, they are now used there.

@adehecq
Copy link
Member Author

adehecq commented May 12, 2022

Sorry, I did not realize that I did not look at the latest commit and the richdem related functions had already been moved !

@rhugonnet rhugonnet added the priority Needs to be fixed rapidly label Aug 1, 2023
@rhugonnet rhugonnet mentioned this issue Sep 6, 2023
Open
@rhugonnet
Copy link
Member

This is closed by #530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right priority Needs to be fixed rapidly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adehecq @rhugonnet