-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make interp_points
robust to non-equal grids and impractical default SciPy arguments
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhugonnet
changed the title
Fix default kwargs in
Make Feb 7, 2024
interp_points
interp_points
robust to non-equal grids and impractical default SciPy arguments
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Merging this bug fix/improvement as it has pretty serious impact on xDEM, can be reviewed a posteriori. |
This was referenced Mar 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
interp_points
consistent between equal and regular grid by using bothmap_coordinates
andinterpn
from SciPy depending on the grid,prefilter
argument ofmap_coordinates
that created large data gaps,method
argument formap_coordinates
by mapping it into anorder
argument,test_xy2ij
.Resolves #483
TO-DO:
AREA_OR_POINT
argument between the methods.