Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a parent class RasterBase for Mask and Raster? #387

Open
rhugonnet opened this issue Aug 9, 2023 · 0 comments
Open

Create a parent class RasterBase for Mask and Raster? #387

rhugonnet opened this issue Aug 9, 2023 · 0 comments
Labels
architecture Need to re-organize or re-structure something test-suite

Comments

@rhugonnet
Copy link
Member

Need to think about this a bit, but it'd probably make things more consistent. Maybe also the occasion to bring the core functionalities in one place before writing #383, to test things?

Right now, Mask is a subclass of Raster. However, as currently defined, Raster.data cannot be a bool... So mypy's typing error are ignored for a few functions.
Maybe it would make more sense to have a parent class RasterBase, that allows all data types and only contains the core functionalities?
@rhugonnet rhugonnet mentioned this issue Aug 9, 2023
Merged
@rhugonnet rhugonnet added test-suite architecture Need to re-organize or re-structure something labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture Need to re-organize or re-structure something test-suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhugonnet