-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollbar integration #752
base: main
Are you sure you want to change the base?
Rollbar integration #752
Conversation
This is the 1-1 port from client project. We can improve it as agreed in a follow-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few comments
@@ -12,6 +12,7 @@ stages: | |||
env: | |||
global: | |||
- DDEV_NO_INSTRUMENTATION=true | |||
- ROLLBAR_SERVER_TOKEN=df6ce617465b4980afdecc95ed1b42de | |||
- PANTHEON_GIT_URL="ssh://codeserver.dev.5acc1750-abf0-47ef-a6d8-6890a6efaca8@codeserver.dev.5acc1750-abf0-47ef-a6d8-6890a6efaca8.drush.in:2222/~/repository.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off topic - now with the Codespace integration, we can probably remove the Pantheon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's more a PM question, if they need persistent demo stuff or not.
@isapisa @nora-novak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's needed.
composer.patches.json
Outdated
@@ -32,6 +32,9 @@ | |||
}, | |||
"drupal/seckit": { | |||
"d.o. #3206728": "https://www.drupal.org/files/issues/2024-09-06/seckit-2_x-src-field-length-3206728-8.patch" | |||
}, | |||
"drupal/rollbar": { | |||
"memory issues": "patches/3432364-rollbar-vars.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a do issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Amitai Burstein <[email protected]>
No description provided.