Fix/Mobile search

[kkatusic]

• cannot enter search term on mobile from giveth homepage #4860

Summary by CodeRabbit

• New Features

  • Enhanced the SearchInput component to allow search term submission via both Enter key and a submit button.
  • Improved usability with a form structure that triggers search term processing on form submission.

• Bug Fixes

  • Ensured input validation checks for a minimum length before submitting the search term.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 4:15pm

[coderabbitai]

Walkthrough

The SearchInput component in src/components/SearchInput.tsx has been updated to improve its functionality by introducing a new handleFormSubmit function. This function validates the input length before setting the search term. The component now uses a <form> element, allowing both Enter key submissions and button clicks to trigger the search. The existing logic for handling key presses and rendering hints remains intact, while the overall structure and behavior of the input handling have been refined.

Changes

File	Change Summary
src/components/SearchInput.tsx	Introduced handleFormSubmit for form submissions; wrapped input elements in a <form>; maintained existing key press handling and rendering logic.

Suggested reviewers

• Hrithik Sampson
• Mohammad P. Ch

Poem

In a field of code, I hop and play,
With forms and inputs, bright as day.
A search term here, a submit there,
With every key press, I dance with flair!
Let's find our treasures, one by one,
In this digital garden, oh what fun! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

src/components/SearchInput.tsx (1)

45-49: Consider extracting duplicate validation logic

The validation logic is duplicated between handleFormSubmit and handleKeyDown. Consider extracting this into a shared function to improve maintainability.

+  function validateAndSetTerm(inputValue: string) {
+    if (inputValue.length > 2) {
+      setTerm(inputValue);
+    }
+  }
+
-  function handleFormSubmit(inputValue: string) {
-    if (inputValue.length > 2) {
-      setTerm(inputValue);
-    }
-  }
+  function handleFormSubmit(inputValue: string) {
+    validateAndSetTerm(inputValue);
+  }

   function handleKeyDown(event: KeyboardEvent<HTMLInputElement>) {
-    if (event.code === 'Enter' && value.length > 2) {
-      setTerm(value);
+    if (event.code === 'Enter') {
+      validateAndSetTerm(value);
     }
   }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 02a85a3 and cd0c808.

📒 Files selected for processing (1)

• src/components/SearchInput.tsx (1 hunks)

🔇 Additional comments (1)

src/components/SearchInput.tsx (1)

55-87: Good improvement for accessibility and mobile UX!

The addition of a proper form wrapper improves accessibility and provides a better mobile experience by:

• Supporting both form submission and keyboard events
• Enabling native mobile keyboard "Go"/"Search" button functionality
• Maintaining proper form semantics

[divine-comedian]

@kkatusic please update branch and nudge Carlos for review!