usdc recurring donation decimals are incorrect and transactions reverts

[divine-comedian]

when adding a recurring donation in usdc it does not seem to parse the decimals correctly.

It does not estimate the amount of months left from the proposed amount to deposit and amount to stream monthly - when going to the confirmaiton modal it shows an amount MUCH lower than the expected, based on the amounts input

in addition it appears the optional donation to giveth toggle is not working correctly - it always applies a donation to giveth even when you toggle it off!!

Screen.Recording.2024-11-10.074357.mp4

[kkatusic]

@divine-comedian done hotfix for this USDC token, problem was with it's decimal, but also found problem related with months number, it wasn't ok. Other problem that you mentioned like applying donation to Giveth if you unchecked it didn't saw and also in video that you sent doesn't showing.

[divine-comedian]

@kkatusic from our discussion yesterday it appears that there is still an error in the flow somewhere

Things we've tested

• make recurring donation with other ERC20 tokens (OP & GIV) - WORKS ✅
• wrap USDC on superfluid app, make recurring donation with already wrapped USDC - WORKS ✅
• make recurring donation with ETH - WORKS ✅
• double checked configs for correct token addresses - WORKS ✅
  -deposit tokens through my recurring donation page - FAILS ❌ - it seems to revoke the approve instead of approve the allowance to deposit the token

It seems this could be related to how we handle depositing tokens or how we batch the deposit function together with creating a stream... bearing in mind USDC is the only token that has 6 decimal precision while all other tokens have 18.. the super USDC token has 18 decimals

[divine-comedian]

@kkatusic needs to review comments from superfluid team

needs to check if it works with new method of fetching and upgrading option with decimal issues.

[divine-comedian]

Gave it a look, tested it out and make some fixes, tested again locally and it looks to be working good! please tag @mateodaza to review the PR and we should push this hotfix on monday.

[kkatusic]

Gave it a look, tested it out and make some fixes, tested again locally and it looks to be working good! please tag @mateodaza to review the PR and we should push this hotfix on monday.

Let's go, thx @divine-comedian

[divine-comedian]

Merged and tested on prod! closing this one.