forked from yardenshoham/gitea-backporter
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PR re-request / self-request review #74
Comments
silverwind
changed the title
Support PR re-request review
Support PR re-request / self-request review
Apr 28, 2023
If user1 requests a review from user2 (user2 previously approved) is that the same as a dismissal of the approval? I don't think so |
I guess it would be rather rude to do that, but yes I think the final count should be a count of the checkmarks essentially. |
So we can implement that easily. A PR will be sent within the next 24 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently this is not possible using the GitHub REST API because re-requests or self-request after approval are not visible in the GitHub review REST API. I think the GraphQL API exposes these and we would have to use that API to correctly parse re-request.
The text was updated successfully, but these errors were encountered: