Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for commit bump during 0.x #4185

Closed
wants to merge 1 commit into from

Conversation

Sharparam
Copy link

This test verifies issue #4184.

Description

As described in the documentation, bumping the major version during the 0.x phase should bump the minor version instead.

However, this does not currently work. This test sets up that scenario.

Related Issue

#4184

Motivation and Context

This test will make sure the bump behaviour stays as intended.

How Has This Been Tested?

I have run the test locally on my machine and it behaves as expected (currently failing of course).

Screenshots (if appropriate):

N/A

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. (The new test fails by design)

@HHobeck
Copy link
Contributor

HHobeck commented Sep 4, 2024

I think that is not correct:

[TestCase("Minor change\n\n+semver:minor", "0.1.1-1")]

@Sharparam
Copy link
Author

Since the middle/minor part becomes the major essentially during 0.x, I moved the minor down to the patch level to follow suit.

However, if we consider the discussion in the linked issue:

Anyway it feels like +semver: breaking has a special semantic and needs to be (if we want to support this behavior) separated from the major-version-bump-message configuration.

Then it might make more sense to adjust this new test to only consider +breaking, +feature and '+fix', if they're going to be treated separately?

@arturcic
Copy link
Member

Closing in favor of #4308

@arturcic arturcic closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants