Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGetVersionV2 doesn't generate valid version number #781

Closed
gep13 opened this issue Feb 8, 2016 · 8 comments
Closed

NuGetVersionV2 doesn't generate valid version number #781

gep13 opened this issue Feb 8, 2016 · 8 comments
Labels

Comments

@gep13
Copy link
Member

gep13 commented Feb 8, 2016

...when using certain feature branch names.

I have created a sample repository to demonstrate this issue, you can find it here:

https://github.com/gep13/GitVersionTest

Steps to reproduce

  1. Clone the repo
  2. cd into repo
  3. Run .\build.ps1
  4. Verify that build works correctly
  5. Do git checkout feature/Gh-567 and run .\build.ps1 and verify that build works correctly
  6. Do git checkout feature/567 and run .\build.ps1 and verify that build does not work correctly

image

The difference between the two feature branches in this repo is that one has a prefix that contains letters, but the other doesn't.

If we are going to have a variable called NuGetVersionV2, then we are asserting that this will be a valid NuGet Version number of NuGet version 2.x. If this is not the case, then we should not include a version number for this property.

@tesharp
Copy link

tesharp commented May 26, 2016

Having the same problem:

'1.3.0-3cd5qnmw-server-0122' is not a valid version string.

Seems to fail if metadata starts with number and not letters.

@pascalberger
Copy link
Member

This issue was fixed in NuGet 3.5.0-rc1: NuGet/Home#1743 (comment)

But since the variable is explicitely for NuGet version 2.x use, IMHO we should still fix this in GitVersion.

@JakeGinnivan
Copy link
Contributor

Completely agree, NuGetv2 should fix this absolutely

@asbjornu
Copy link
Member

asbjornu commented Nov 3, 2016

As @nshenoy points out in #1067 (comment), NuGet 3.5 is RTM and solves this problem. Doesn't that mean this issue can be closed?

@pascalberger
Copy link
Member

@asbjornu See discussion above. The consensus was to have this fixed in GitVersion since variable is explicitely for use with NuGet version 2.x.

@asbjornu
Copy link
Member

asbjornu commented Nov 3, 2016

@pascalberger: I see.

@nshenoy
Copy link
Contributor

nshenoy commented Nov 3, 2016

Also in #1067 @aarondandy pointed out the following rules for a proper NuGet 2.x prerelease tag:

  • Prerelease can not start with a number
  • Prerelease can not start or end with a dash

And the tag itself cannot be more than 20 characters.

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 29, 2019
@stale stale bot closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants