-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGetVersionV2 doesn't generate valid version number #781
Comments
Having the same problem: '1.3.0-3cd5qnmw-server-0122' is not a valid version string. Seems to fail if metadata starts with number and not letters. |
This issue was fixed in NuGet 3.5.0-rc1: NuGet/Home#1743 (comment) But since the variable is explicitely for NuGet version 2.x use, IMHO we should still fix this in GitVersion. |
Completely agree, NuGetv2 should fix this absolutely |
As @nshenoy points out in #1067 (comment), NuGet 3.5 is RTM and solves this problem. Doesn't that mean this issue can be closed? |
@asbjornu See discussion above. The consensus was to have this fixed in GitVersion since variable is explicitely for use with NuGet version 2.x. |
@pascalberger: I see. |
Also in #1067 @aarondandy pointed out the following rules for a proper NuGet 2.x prerelease tag:
And the tag itself cannot be more than 20 characters. |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
...when using certain feature branch names.
I have created a sample repository to demonstrate this issue, you can find it here:
https://github.com/gep13/GitVersionTest
Steps to reproduce
cd
into repo.\build.ps1
git checkout feature/Gh-567
and run.\build.ps1
and verify that build works correctlygit checkout feature/567
and run.\build.ps1
and verify that build does not work correctlyThe difference between the two feature branches in this repo is that one has a prefix that contains letters, but the other doesn't.
If we are going to have a variable called NuGetVersionV2, then we are asserting that this will be a valid NuGet Version number of NuGet version 2.x. If this is not the case, then we should not include a version number for this property.
The text was updated successfully, but these errors were encountered: