Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] We need to consider somehow the IGitVersionConfiguration::Ignore property #3461

Closed
HHobeck opened this issue Apr 6, 2023 · 2 comments · Fixed by #3953
Closed

[Feature] We need to consider somehow the IGitVersionConfiguration::Ignore property #3461

HHobeck opened this issue Apr 6, 2023 · 2 comments · Fixed by #3953
Labels
feature
Milestone
6.0.0-beta.7

Comments

@HHobeck
Copy link
Contributor

HHobeck commented Apr 6, 2023

Detailed Description

We need to consider somehow the IGitVersionConfiguration::Ignore property when bumping the version number using existing git tags.

Context

Possible Implementation

The implemenatation needs to be changed in: NonTrunkBasedVersionCalculatorBase::CalculateIncrementedVersion
@HHobeck HHobeck added the feature label Apr 6, 2023
@HHobeck HHobeck added this to the 6.x milestone Apr 6, 2023
@HHobeck HHobeck mentioned this issue Apr 6, 2023
Merged
5 tasks
@arturcic arturcic added stale and removed stale labels Jun 30, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Sep 29, 2023
@arturcic arturcic removed the stale label Sep 29, 2023
@arturcic arturcic added stale and removed stale labels Oct 30, 2023
@HHobeck HHobeck modified the milestones: 6.x, 7.x Jan 11, 2024
@HHobeck HHobeck modified the milestones: 7.x, 6.x Feb 15, 2024
@HHobeck HHobeck mentioned this issue Feb 15, 2024
Merged
5 tasks
@HHobeck HHobeck mentioned this issue Mar 13, 2024
Merged
5 tasks
@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.7 Mar 15, 2024
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0-beta.7 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
6.0.0-beta.7
Development

Successfully merging a pull request may close this issue.

Consider somehow the IGitVersionConfiguration::Ignore property HHobeck/GitVersion
2 participants
@arturcic @HHobeck