Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Extend the /updateprojectfiles parameter to update the 'Version' element #2359

Closed
akordowski opened this issue Jul 16, 2020 · 4 comments · Fixed by #2361
Closed
Milestone

Comments

@akordowski
Copy link
Contributor

Is your improvement request related to a problem? Please describe.
I use GitVersion in a DevOps Pipeline. After using the dotnet pack command the Nuget Package still had the default 1.0.0 version number. I also used the /verbosity Diagnostic to check if the .csproj files are updated, but got no diagnostic info.

Detailed Description

  1. I propose to extend the ProjectFileUpdater class to update the <Version> element in the .csproj file aswell.
  2. I propose to add diagnostic log outputs to the ProjectFileUpdater class, to have a better overview which classes are updated.

Context

Using GitVersion in a DevOps scenario I was expecting that the <Version> element is changed.

@akordowski
Copy link
Contributor Author

I would like to contribute the changes, if I got the OK.

@asbjornu
Copy link
Member

I think this sounds like a welcome contribution. A PR would be appreciated. 🙏

@akordowski
Copy link
Contributor Author

Ok, than I will provide a PR in the next days. Thanks!

@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.5.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants