-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow due to infinite loop falling back to branch config #1518
Comments
This is now failing on a build with the 4.0 version of GitVersion on a tagged build. This should not happen if I'm interpreting the docs correctly. |
Another update. On the repo we had issues, we did a massive branch clean-up, and this seems to have helped for now. |
This problem will just not go away. Any chance at all there is a potential fix for this issue? |
I've also encountered this issue recently. Will GitVersion support Microsoft's Release Flow as a first-class citizen eventually? |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
So you will never fix this |
This happened to me on a merge commit. |
@thepirat000, there is no "you", it's "we". No one is getting paid to work on GitVersion, so unless someone submits a pull request to fix this issue, it's not going to get fixed. So far we haven't gotten a single reproduction, not a public repository where the problem exists, not a |
Hi there. I'm going to close this issue because no one is providing steps to reproduce. In advance the whole mechanism to determine the branch configuration has been changed. Thus this should not happened in version 6.x anymore. Please reopen this issue or create a new bug if the stack overflow issue still persists. Cheers. |
🎉 This issue has been resolved in version 6.0.0-beta.1 🎉 Your GitReleaseManager bot 📦🚀 |
In a repository that only has a master and a release branch, during a pull request build (TFS 2018 Update 2), GitVersion goes into an infinite loop and eventually errors out with a stackoverflow error.
This happens with both 3.6.5 and the latest 4.0.0 version (4.0.1 version of the VSTS task and using the latest version of GitVersion from Chocolatey).
I have attached the GitVersion.yml file and the logs from our latest failing build. This yml config fixes the issue by forcing pull requests to use
Patch
rather thanInherit
for theincrement
setting. When it defaults toInherit
, it cannot figure out the fallback version.GitVersion-log.zip
GitVersion.yml.zip
The text was updated successfully, but these errors were encountered: