ERROR building 0.5.2

[omershlo]

[RalfJung]

With rust-lang/rust#63201 the doctest feature got stabilized, likely that is the problem?

[Gilnaa]

With rust-lang/rust#63201 the doctest feature got stabilized, likely that is the problem?

At least on my machine, this builds on nightly with a warning

[Gilnaa]

rustc version?

[omershlo]

yep, rustup update did the work .
Thank you gentlemen

[frondeus]

Hello, note this is an breaking change for us. We are using older version of rustc (from july, and it's not so easy to upgrade it at once in our company where we have dozens of crates) so CI stopped to build (as Cargo.lock is gitignored in libraries)

This cfg_doctest is indeed stable but still it bumped minimum rust version of the project and IMHO it should be treated as breaking change.

[Gilnaa]

I'll try to gate it on a minimum nightly version. What nightly are you using?

[RalfJung]

We support ancient Rust versions back to Rust 1.20, so old Rust can't be the problem. Also to be clear, as far as I am concerned bumping the MSRV is not a breaking change. We'll be conservative in doing so though. But lucky enough we didn't bump it, we still test against Rust 1.20.

Or are you saying you are using an old nightly? That's a really bad idea... but if @Gilnaa wants to do the work to support that I will not stop them.

@Gilnaa my proposal would be to treat ancient nightlies like stable, that way they do not need a separate code path. Or better, doctest is stable now -- so on Rust 1.40+, we can just use it, and we never use feature at all.

[Gilnaa]

I agree, we should just use doctests when we use a >1.40 compiler.

Since this is not really a feature of memoffset, but part of the CI, I see no reason not to do it

[RalfJung]

Agreed, not using feature any more is an improvement :)

[Gilnaa]

@frondeus Would still like to know what your nightly version you're using (for testing purposes).

[Gilnaa]

Solved by #32, published in v0.5.3

[frondeus]

Thank you 🙇. We are using 2019-07-02 nightly which is pretty old, but I discussed it with my superior and we will switch very soon to newest version (2019-10-31 I think) where problem does not exist.

Anyway - I checked 0.5.3 is working, so thank you <3