Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation with pip fails #3

Open
nbeliy opened this issue Nov 27, 2020 · 3 comments
Open

Installation with pip fails #3

nbeliy opened this issue Nov 27, 2020 · 3 comments

Comments

@nbeliy
Copy link

nbeliy commented Nov 27, 2020

Installation using pip fails due to syntax error in mp2rage/version.py:

python3 -m pip install git+https://github.com/Gilles86/pymp2rage
Collecting git+https://github.com/Gilles86/pymp2rage
  Cloning https://github.com/Gilles86/pymp2rage to /tmp/pip-40es0w05-build
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-40es0w05-build/setup.py", line 8, in <module>
        exec(f.read())
      File "<string>", line 23
        "License :: OSI Approved :: Apache License, 2.0"",
                                                         ^
    SyntaxError: EOL while scanning string literal
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-40es0w05-build/
@gjheij
Copy link

gjheij commented Dec 3, 2020

Hi! If this has prevented you from using the package, you can run git clone https://github.com/Gilles86/pymp2rage.git to clone the repo and change line 23 "License :: OSI Approved :: Apache License, 2.0"" to "License :: OSI Approved :: Apache License, 2.0" and line 47 LICENSE = "Apache License, 2.0"" to LICENSE = "Apache License, 2.0" in the pymp2rage/version.py file, then run python setup.py develop from within the cloned repo directory. That should do it.

@nbeliy
Copy link
Author

nbeliy commented Jan 11, 2021

Sorry for the late response, I've missed a notification.

Yes, it easy to fix, the issue was just to signal it.

@mckeuken
Copy link

mckeuken commented Sep 9, 2021

I created a pull request with the suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants