-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong agreement URL #3
Comments
Here is a lot more info on that error, and explanations of how to properly architect the agreement url: acmesh-official/acme.sh#1112 And here's roughly how to grab that current agreement URL: ACME_AGREEMENT=$(echo "$response" | _egrep_o 'terms-of-service" *: *"[^"]*"' | cut -d '"' -f 3)
if [ -z "$ACME_AGREEMENT" ]; then
ACME_AGREEMENT=$(echo "$response" | _egrep_o 'termsOfService" *: *"[^"]*"' | cut -d '"' -f 3)
fi
export ACME_AGREEMENT Looks to me like we'd want to do that ^^ after this line: https://github.com/Gibby/docker-letsencrypt-dns-digitalocean/blob/master/container-files/run.sh#L14
|
@Gibby mind if I take a crack at this? |
The terms of service agreement url is plainly returned here: https://acme-staging.api.letsencrypt.org/directory {
"8dHrmIRnU54": "https://community.letsencrypt.org/t/adding-random-entries-to-the-directory/33417",
"key-change": "https://acme-staging.api.letsencrypt.org/acme/key-change",
"meta": {
"caaIdentities": [
"letsencrypt.org"
],
"terms-of-service": "https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf",
"website": "https://letsencrypt.org/docs/staging-environment/"
},
"new-authz": "https://acme-staging.api.letsencrypt.org/acme/new-authz",
"new-cert": "https://acme-staging.api.letsencrypt.org/acme/new-cert",
"new-reg": "https://acme-staging.api.letsencrypt.org/acme/new-reg",
"revoke-cert": "https://acme-staging.api.letsencrypt.org/acme/revoke-cert"
} ... but I'm just not seeing the actual letsencrypt commands where this is pulled. |
@mborn319 go ahead and do a PR if you need it. I actually don't use this anymore but left it up if anybody else was using it. letsencrypt.sh is coming from https://github.com/lukas2511/letsencrypt.sh so if it is working from there it should work in the container. |
@mborn319 is this still an issue? |
I never got this working, and I couldn't figure what a "proper" fix would be in the source code. I'd be happy to help if I knew what to fix! If this plugin is using |
I get the following error from letsencrypt:
Is this something I can help fix? I looked, but I don't see any agreement URL hard-coded in the source.
Full error info:
The text was updated successfully, but these errors were encountered: