Fix unwanted behaviour with show-coordinates

[Konicai]

• If reducedDebugInfo gamerule is enabled, clients will not have the coordinate display. Whenever the gamerule is set/toggled the changes will apply immediately. Note that gamerules are dimensions specific.
• If show-coords is disabled in the geyser config, clients will not have the coordinate display.
• Removes the option in the client's settings if either of the above apply

Client preference is only remembered during a single session (it is enabled by default at the start). From what I understand it would require us to start storing information. Creating a whole database just for this would seem overkill. We could implement another config option that dictates whether the client preference is initially enabled or disabled.

The concern with rtm's PR was that the javadoc wasn't accurate (I would have PR'd into his fork but there were dependency issues).

resolves #1700

[Konicai]

Also I'd propose setting the showcoordinates gamerule in the StartGamePacket to false because the client will always see 0, y, 0 between then and here, where the decision is calculated properly.

[Camotoy]

Can you set the reduced debug info also from the JoinGamePacket? Just shove a session.setReducedDebugInfo(packet.isReducedDebugInfo()); after a new line below the isImmediateRespawn stuff. Then this looks good for merge for me.

[Konicai]

Can you set the reduced debug info also from the JoinGamePacket? Just shove a session.setReducedDebugInfo(packet.isReducedDebugInfo()); after a new line below the isImmediateRespawn stuff. Then this looks good for merge for me.

Sorry, I can't seem to find the isImmediateRespawn stuff that you're talking about?

[Camotoy]

https://github.com/GeyserMC/Geyser/blob/master/connector/src/main/java/org/geysermc/connector/network/translators/java/JavaJoinGameTranslator.java#L87

[Konicai]

I was looking in StartGame packet 🤦‍♂️

Addressed.