Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix player rotation lock while riding boats for 1.16.210+ #2114

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Fix player rotation lock while riding boats for 1.16.210+ #2114

merged 2 commits into from
Apr 9, 2021

Conversation

davchoo
Copy link
Member

@davchoo davchoo commented Apr 8, 2021

No description provided.

@Camotoy
Copy link
Member

Camotoy commented Apr 8, 2021

Does this affect any other mount?

@davchoo
Copy link
Member Author

davchoo commented Apr 8, 2021

I'm pretty sure boats are the only mount that has rotation locking.

@Camotoy
Copy link
Member

Camotoy commented Apr 8, 2021 •
edited
Loading

Around line 125, can you set the RIDER_ROTATION_OFFSET back to 0f so it's cleared on dismount?

@davchoo
Copy link
Member Author

davchoo commented Apr 9, 2021

Should I also add a check for the protocol version?

@Camotoy
Copy link
Member

Camotoy commented Apr 9, 2021

Yeah, good thinking.

@Camotoy Camotoy merged commit e549792 into GeyserMC:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camotoy Camotoy Camotoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davchoo @Camotoy