Dimension switching cleanup #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up dimension switching logic that should no longer be needed. Also fixes above Nether Bedrock building dimension switching.
rtm516
approved these changes
Dec 17, 2020
|
Is there a way to make Github regenerate artifacts here? I have tested it and it works with the current artifacts, and I just want to try it with newer commits that have happened since, or if you think it will just work it would be nice if this could be merged... |
|
Sure, will do now. |
|
Sorry I didn't get back to this, just didn't have time to do a thorough testing yet. |
|
No worries! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up dimension switching logic that should no longer be needed. Also fixes above Nether Bedrock building dimension switching.