Added a simple way to get a player by their xuid

[janrabek]

Simple method to get a player by their Xbox UUID. Can be used by Bungee plugins that need to access the GeyserSession

[Tim203]

While this method won't be called a lot, I still recommend using plain for loops

[janrabek]

Any reasons for that?

[Tim203]

For loops are better for performance.
While it might look fancy, I prefer performance xd

[rtm516]

Might also be better to name it GeyserConnector#getSessionByXboxUuid since that's more descriptive.
Also please add a JavaDoc comment to the method and if you can find the few for loops in the code that do this and replace them with this method. I think there are ones in SkinUtils.java and some of the commands

[janrabek]

Might also be better to name it GeyserConnector#getSessionByXboxUuid since that's more descriptive.
Also please add a JavaDoc comment to the method and if you can find the few for loops in the code that do this and replace them with this method. I think there are ones in SkinUtils.java and some of the commands

I named this method getPlayer... because the corresponding methods are named "addPlayer" and "removePlayer". But I can easily change the name of it and replace the for loops.

[rtm516]

I named this method getPlayer... because the corresponding methods are named "addPlayer" and "removePlayer".

Ah your correct, leave the method name as-is for now then.

[janrabek]

I named this method getPlayer... because the corresponding methods are named "addPlayer" and "removePlayer".

Ah your correct, leave the method name as-is for now then.

And just found out that nowhere the player is retrieved by the XUID, only by the UUID of the player entity. Should I create an extra method for that?

[rtm516]

And just found out that nowhere the player is retrieved by the XUID, only by the UUID of the player entity. Should I create an extra method for that?

If you don't mind, would make sense to roll it into this PR since they are very simmilar.

[janrabek]

done

[rtm516]

Can you also add {} to some of the other if statements to follow the styling of the project?

Resolved