Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files uploaded to Modrinth should have different names. #3709

Closed
derspyy opened this issue Apr 28, 2023 · 2 comments · Fixed by #3823
Closed

Files uploaded to Modrinth should have different names. #3709

derspyy opened this issue Apr 28, 2023 · 2 comments · Fixed by #3823
Labels
Feature Request A feature request.

Comments

@derspyy
Copy link
Contributor

derspyy commented Apr 28, 2023

What feature do you want to see added?

it would be interesting if every file uploaded to modrinth had its own filename because updating through ferium is currently broken.

➡️ gorilla-devs/ferium#140

my idea is for either the commit or snapshot number be appended to the filename for both geyser and floodgate.
(also possibly remove the capital letters from geyser's file names for consistency) 😊

some idea examples:

geyser-fabric-2.1.0+build.94.jar < similar to sodium's
geyser-2.1.0+fabric.8a25afb.jar < similar to starlight's

Are there any alternatives?

currently, none

@derspyy derspyy added the Feature Request A feature request. label Apr 28, 2023
@Gaming32
Copy link

Removing this line should be all that needs to happen.

@derspyy
Copy link
Contributor Author

derspyy commented Jun 8, 2023

for reference, my solution was a name similar to sodium's.

closing since it's been addressed in a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants