-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding UriAugmenterService in order to augment Url generation. #56
Conversation
…tent and expand it into several QueryString parameterizedd Urls.
… own implementation. Adding NullUriAugmenterService to AddSitmaps services extension. Including documentation into solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add examples of a custom AugmentService in the documentation.
src/Geta.Optimizely.Sitemaps/Services/NullUriAugmenterService.cs
Outdated
Show resolved
Hide resolved
src/Geta.Optimizely.Sitemaps/Services/NullUriAugmenterService.cs
Outdated
Show resolved
Hide resolved
src/Geta.Optimizely.Sitemaps/Services/NullUriAugmenterService.cs
Outdated
Show resolved
Hide resolved
Enhancing README.md with example UriAugmenterService. Adding options and integrating options into Foundation project. Renaming NullUriAugmenterService to DefaultUriAugmenterService.
I tried to do the deployment for the Foundation project, but couldn't get it to deploy for some reason. |
@jeff-fischer-optimizely This is a standard Foundation project, if you follow Optimizely's instructions, it should work. |
It turned out to be a whole series of issues. Here are the ones that I can remember:
I have successfully tested it now, but it just doesn't hit the section for PersonListpage within the custom UriAugmenterService. Thanks, |
Remove UriAugmenterServiceImplementationFactory on SitemapOptions. Redo the Startup AddSitemaps call after changing AddSitemaps extension method overloads. Minor updates to SitemapUriParameterAugmenterService logic.
@jeff-fischer-optimizely I do not see any changes from the previous review. |
… to show how the optionsAction does not appear to be getting called.
Hey @marisks, let me know if there are any other updates and I'll put them together. Hoping to wrap this up ASAP. |
...Foundation/src/Foundation/Infrastructure/Cms/Services/SitemapUriParameterAugmenterService.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Māris Krivtežs <[email protected]>
…SitemapUriParameterAugmenterService.cs Co-authored-by: Māris Krivtežs <[email protected]>
README updates to provide procedure for adding UriAugmenterService.
Some of the pages are not as simple as standard pages that need to be added to the sitemap. The Url needs to be augmented in order to be correctly indexed by google as the page requires Url parameters in order to correctly display data.
The UriAugmenterService takes an IContent, CurrentLanguageContent and Uri and turns it into an IEnumerable in order to take a single Uri and convert it into many possible Uris that are required to be indexed.
Additionally, this PR includes several files that were on disk (.gitignore, .md and nuget.config) into the solution for easy modification and fixes an uncompiled Regular Expression which will cause unnecessary excessive JIT compilation.