Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android list is inverted when custom flatlist style is used #2016

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix: android list is inverted when custom flatlist style is used #2016

merged 2 commits into from
Mar 17, 2023

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Mar 17, 2023 •
edited
Loading

🎯 Goal

fixes #2012

🧪 Testing

Add the following prop

        <MessageList
              additionalFlatListProps={{
                style: { backgroundColor: '#ffffff' },
              }}
            />

the list should behave normally

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai requested review from khushal87 and vanGalilea and removed request for khushal87 March 17, 2023 10:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@vanGalilea vanGalilea merged commit edabea1 into develop Mar 17, 2023
@vanGalilea vanGalilea deleted the android-inverted-list-fix branch March 17, 2023 15:15
@github-actions github-actions bot mentioned this pull request Mar 17, 2023
Merged
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanGalilea vanGalilea vanGalilea approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MessageList renders upside-down on Android
3 participants
@santhoshvai @stream-ci-bot @vanGalilea