Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry ability for image load failure #2011

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Mar 15, 2023

🎯 Goal

Fixes #1966

Extra: refactor useLoadingImage to be cleaner

🎨 UI Changes

The color of retry btn is grey

image

the behaviour is here, ignore the retry btn color

If user taps in the whole grey card, retry will happen.. here the user taps 3 times and the 3rd time the image loads successfully

Simulator.Screen.Recording.-.iPhone.14.-.2023-03-15.at.15.18.22.mp4

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai changed the title Image reload feat: add retry ability for image load failure Mar 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@vanGalilea vanGalilea merged commit 3b5a315 into develop Mar 16, 2023
@vanGalilea vanGalilea deleted the image-reload branch March 16, 2023 15:24
@github-actions github-actions bot mentioned this pull request Mar 16, 2023
@neopit
Copy link

neopit commented Mar 17, 2023

@santhoshvai , @vanGalilea

I am currently working on a project where we need to override some loading indicator in order to follow the design of our company. We can override these indicators through this props on the

  • ImageLoadingIndicator
  • ImageLoadingFailedIndicator

On this PR, the ImageReloadIndicator is introduced but it seems not possible to override this indicator if needed like the others mentioned above.

Is it possible to allow to override this new ImageReloadIndicator as well?
Thx

@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error loading image when app put in background
4 participants